Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run validate errors out at npm run check-coverage #9

Closed
sarbbottam opened this issue Mar 17, 2016 · 5 comments
Closed

npm run validate errors out at npm run check-coverage #9

sarbbottam opened this issue Mar 17, 2016 · 5 comments

Comments

@sarbbottam
Copy link
Contributor

Am I the only one finding error for npm run validate, to be precise npm run check-coverage

coverage directory does exist, I have verified it with npm run cover.

ERROR: check-coverage: None-Zero Exit(1);

npm ERR! Darwin 15.3.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "validate"
npm ERR! node v5.8.0
npm ERR! npm  v3.7.3
npm ERR! code ELIFECYCLE
npm ERR! eslint-find-new-rules@0.0.0-semantically-released validate: `npm-run-all --parallel lint cover --sequential check-coverage`
npm ERR! Exit status 1

吽 npm run check-coverage

> eslint-find-new-rules@0.0.0-semantically-released check-coverage /Users/sabandyo/GitHub/eslint-find-new-rules
> nyc check-coverage --statements 71 --branches 33 --functions 100 --lines 71

ERROR: No coverage files found.

npm ERR! Darwin 15.3.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "check-coverage"
npm ERR! node v5.8.0
npm ERR! npm  v3.7.3
npm ERR! code ELIFECYCLE
npm ERR! eslint-find-new-rules@0.0.0-semantically-released check-coverage: `nyc check-coverage --statements 71 --branches 33 --functions 100 --lines 71`
npm ERR! Exit status 1

Thanks!!

@kentcdodds
Copy link
Owner

Nope, I'll bet this is the same issue as here:
https://github.com/kentcdodds/webpack-validator/issues/21
kentcdodds/configuration-validator#9

Let me remove check-coverage from the validate script until we can work out what's going on... You're not on Windows are you? This is odd...

@sarbbottam
Copy link
Contributor Author

You're not on Windows are you?

OS X El Capitan (10.11.3)

@sarbbottam
Copy link
Contributor Author

This is strange, nyc check-coverage is working for me in the same env for another project. Let me dig a bit further.

@kentcdodds
Copy link
Owner

Note: I've pushed some updates so you should be able to update your fork 👍

@sarbbottam
Copy link
Contributor Author

Thanks for the video links, I generally do the following

remote add upstream git@github.com:kentcdodds/eslint-find-new-rules.git
fetch upstream
rebase upstream

addup = remote add upstream
fetchup = fetch upstream
rebaseup = rebase upstream/master

kentcdodds pushed a commit that referenced this issue Mar 17, 2016
fixed #9 use `ava` instead of `npm t` for `cover`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants