New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(matchers): support asymmetric matchers #37
Conversation
Oh, there're some coverage problems. I will add some tests... |
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 152 158 +6
Branches 39 41 +2
=====================================
+ Hits 152 158 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super! Thanks!
Actually, would you like to add documentation for this feature? |
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the |
@kentcdodds Oh, I missed that. Thank you for notifying me! I will add it after busy days... |
resolve #36
What: Support asymmetric matchers (#36)
Why: Using asymmetric matchers make tests easier
How: see https://github.com/facebook/jest/blob/be4bec387d90ac8d6a7596be88bf8e4994bc3ed9/packages/expect/src/jasmine_utils.js#L36
This can support
expect@^21 || ^22
, andjest-matchers@^19 || ^20
, but I do not know how to add exclusive-or-ly those peerDeps. Is there a way to do so?