Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom scripts #106

Closed
wants to merge 1 commit into from

Conversation

piecyk
Copy link

@piecyk piecyk commented Nov 30, 2019

What:

Add support for overriding or creating custom scripts.

Why:

Rather than making a fork, create custom scripts on top of kcd-scripts

How:

By passing custom scripts path to run-script.
Example https://github.com/piecyk/custom-kcd-scripts

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@piecyk
Copy link
Author

piecyk commented Dec 1, 2019

Hmm looking on it maybe better would be to use env, something like master...piecyk:custom-wip

then it will be easy to extend kcd-scripts, update default configuration and add extra scripts like
https://github.com/piecyk/custom-kcd-scripts/tree/use-custom-wip

@kentcdodds What do you think? Really would like to use this rather than making my own fork 🙏 Loving the util functions 👍Overall proposed changes are minimal and don't affect how the scripts work. If you think that this is something that could be merged ping me 👋Maybe can create some tests 🙈Thanks for your hard work 👏

@kentcdodds
Copy link
Owner

Thanks for this @piecyk! I worry that if I enable people to not fork this, that they'll start asking for more features from this package and I don't have the bandwidth to maintain this package for anyone's use cases other than my own.

So if you'd like to make your own version of this package that has all those features, please feel free, but I'm not going to accept this. I'm really sorry! I hope you understand.

@kentcdodds kentcdodds closed this Dec 1, 2019
@piecyk
Copy link
Author

piecyk commented Dec 1, 2019

Yes, I understand. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants