run tsc -noemit on Typescript files during lint-staged
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt" (#1) * Run tsc on staged files when TypeScript is enabled
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 18 18
Lines 332 332
Branches 78 78
=======================================
Hits 291 291
Misses 34 34
Partials 7 7
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 5.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
For TypeScript projects, developers would like to verify that their .ts and .tsx files compile in the lint-staged stop by running
tsc -noemit
Format,lintandtestwere running on .ts and .tsc files, but nothing was checking that TypeScript code compiled correctly.Why
Enable safer Typescript development
How
Used ifTypeScript from utils to check if TypeScript is enabled.
If enabled, run tsc --noEmilt on all .ts and .tsx files
I ran tests with a local project, but did not see a good way to test within this project. If you have ideas, let me know and i'll implement them.