Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create definition files into provided folder #182

Merged
merged 3 commits into from
Dec 7, 2020

Conversation

marcosvega91
Copy link
Contributor

What: Create definition files into the provided --out-dir

Why: Because definitions were always saved into dist folder. In @testing-lirabry/react-hooks we are using lib as out dir

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #182 (394a4fa) into master (eb35a5d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   85.14%   85.14%           
=======================================
  Files          17       17           
  Lines         424      424           
  Branches      162      162           
=======================================
  Hits          361      361           
  Misses         56       56           
  Partials        7        7           
Impacted Files Coverage Δ
src/utils.js 86.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb35a5d...f70fb7e. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this change solves your problem 🤔

@marcosvega91
Copy link
Contributor Author

You're right I have forgotten a file 😄

@marcosvega91
Copy link
Contributor Author

should be good now, sorry for that 👍

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👍

@kentcdodds kentcdodds merged commit bc40408 into kentcdodds:master Dec 7, 2020
@kentcdodds
Copy link
Owner

@all-contributors please add @marcosvega91 for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @marcosvega91! 🎉

@github-actions
Copy link

github-actions bot commented Dec 7, 2020

🎉 This PR is included in version 7.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants