Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove --no-ts-defs before using babel #184

Merged

Conversation

marcosvega91
Copy link
Contributor

What: Remove --no-ts-defs before using babel

Why: Because --no-ts-defs doesn't exist in babel

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #184 (55c9cda) into master (4da07c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files          17       17           
  Lines         424      424           
  Branches      162      162           
=======================================
  Hits          363      363           
  Misses         54       54           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da07c4...55c9cda. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@kentcdodds kentcdodds merged commit 6b700e6 into kentcdodds:master Dec 10, 2020
@github-actions
Copy link

🎉 This PR is included in version 7.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@marcosvega91 marcosvega91 deleted the pr/remove_no_type_using_babel branch December 10, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants