feat(precommit): support lint-staged --config CLI flag #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the precommit script to use lint-staged's --config CLI flag and adds related tests. Resolves kentcdodds#24
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=========================================
+ Coverage 67.06% 72.86% +5.8%
=========================================
Files 22 21 -1
Lines 337 328 -9
Branches 80 79 -1
=========================================
+ Hits 226 239 +13
+ Misses 83 66 -17
+ Partials 28 23 -5
Continue to review full report at Codecov.
|
macklinu
force-pushed
the
lint-staged-config
branch
from
b8e9e97
to
07f1c1c
Compare
kentcdodds
approved these changes
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This commit refactors the precommit script to use lint-staged's
--configCLI flag and adds relatedtests.
Why:
This PR resolves #24.
How:
I moved some of the contents of
src/scripts/precommit/index.jstosrc/scripts/precommit.js, removing the need to fake cosmiconfig and modeling passing a--configflag to the precommit script by looking at other script files (e.g. lint). The tests should confirm what commands are being run under the hood when executing the precommit script.Checklist:
I wasn't sure which commit message to use - feat, fix, refactor. Feel free to merge this with a different commit message or let me know if you'd like to me to change it for semantic-release purposes. Thanks. 😄