Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup): remove experimentalCodeSplitting from config #82

Merged
merged 2 commits into from
Mar 15, 2019
Merged

fix(rollup): remove experimentalCodeSplitting from config #82

merged 2 commits into from
Mar 15, 2019

Conversation

jeffdetmer
Copy link
Contributor

What: removing experimentalCodeSplitting from the rollup config

Why: as of rollup 1.0.0, the functionality provided by experimentalCodeSplitting is always active. The option has been removed and now throws a warning when part of the rollup config.

How: removed the experimentalCodeSplitting from src/config/rollup.config.js

Checklist:

  • Documentation - N/A
  • Tests - existing tests pass
  • Ready to be merged

as of rollup 1.0.0, experimentalCodeSplitting is always active and has been removed as a valid
option. removing from the config to resolve the warning received during build.
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks!

@kentcdodds kentcdodds merged commit 61e9452 into kentcdodds:master Mar 15, 2019
@kentcdodds
Copy link
Owner

@all-contributors please add @shellthor for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @shellthor! 🎉

@jeffdetmer jeffdetmer deleted the fix-rollup-config branch March 15, 2019 18:44
@kentcdodds
Copy link
Owner

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants