fix: support filtering on tags containing spaces

kentcdodds · Jul 4, 2021 · 681ccda · 681ccda
1 parent ea73355
commit 681ccda
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/app/routes/blog/index.tsx b/app/routes/blog/index.tsx
@@ -118,13 +118,15 @@ function BlogHome() {
 
   function toggleTag(tag: string) {
     setQuery(q => {
-      const newQuery = q.includes(tag)
-        ? q
-            .split(' ')
-            .filter(s => s !== tag)
-            .join(' ')
+      // create a regexp so that we can replace multiple occurrences (`react node react`)
+      const expression = new RegExp(tag, 'ig')
+
+      const newQuery = expression.test(q)
+        ? q.replace(expression, '')
         : `${q} ${tag}`
-      return newQuery.trim()
+
+      // trim and remove subsequent spaces (`react   node ` => `react node`)
+      return newQuery.replace(/\s+/g, ' ').trim()
     })
   }