-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add blog detail page #19
Conversation
✔️ Deploy Preview for kcd-react ready! 🔨 Explore the source changes: 5a9fb30 🔍 Inspect the deploy log: https://app.netlify.com/sites/kcd-react/deploys/60dd9f34688ef00007b381b3 😎 Browse the preview: https://deploy-preview-19--kcd-react.netlify.app |
5bce903
to
f59dc89
Compare
Regarding the candy dispenser, do a lot of posts have embedded jsx/html? We could adjust the prose classes to either do something with embedded html, or attempt to not target it entirely. But I feel like content like that should be positioned in an iframe, with its own styling. Otherwise, we'll always have the chance of missing some (edge) cases. The transparent png at Thoughts? |
Despite the open issues in this PR, I'm okay with getting it merged so that Gil look at some articles on staging. Ready when you are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid progress here 👍
I've added some typography (prose) styles to
tailwind.config.js
so we control blog styles through prose. This felt better than providing custom components to the mdx parser. Prose for blogs, utility classes for everything else.I've also fixed a small typo in the
KCDMdxComponent.components
prop, and I've removed the row-gap from the grid component. The column-gap works great, but the row-gap was only standing in the way.I'm not done yet. I need to add a few more element types, and I'm chatting with the designer about some details. So
to be continued
TODO
/blog/usememo-and-usecallback
png
at/blog/unit-vs-integration-vs-e2e-tests
?