Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blog detail page #19

Merged
merged 5 commits into from
Jul 1, 2021
Merged

feat: add blog detail page #19

merged 5 commits into from
Jul 1, 2021

Conversation

smeijer
Copy link
Collaborator

@smeijer smeijer commented Jun 30, 2021

I've added some typography (prose) styles to tailwind.config.js so we control blog styles through prose. This felt better than providing custom components to the mdx parser. Prose for blogs, utility classes for everything else.

I've also fixed a small typo in the KCDMdxComponent.components prop, and I've removed the row-gap from the grid component. The column-gap works great, but the row-gap was only standing in the way.

I'm not done yet. I need to add a few more element types, and I'm chatting with the designer about some details. So

to be continued

TODO

  • fix candy-dispenser /blog/usememo-and-usecallback
  • what to do with the transparent png at /blog/unit-vs-integration-vs-e2e-tests ?

@netlify
Copy link

netlify bot commented Jun 30, 2021

✔️ Deploy Preview for kcd-react ready!

🔨 Explore the source changes: 5a9fb30

🔍 Inspect the deploy log: https://app.netlify.com/sites/kcd-react/deploys/60dd9f34688ef00007b381b3

😎 Browse the preview: https://deploy-preview-19--kcd-react.netlify.app

@smeijer
Copy link
Collaborator Author

smeijer commented Jul 1, 2021

Regarding the candy dispenser, do a lot of posts have embedded jsx/html? We could adjust the prose classes to either do something with embedded html, or attempt to not target it entirely. But I feel like content like that should be positioned in an iframe, with its own styling.

Otherwise, we'll always have the chance of missing some (edge) cases.

The transparent png at /blog/unit-vs-integration-vs-e2e-tests can easily be fixed by adding a light background color to .prose img to simulate the effect of the current site (transparent on white), but not sure if that has your preference, because then you'll lose the benefit of transparent images.

Thoughts?

@smeijer
Copy link
Collaborator Author

smeijer commented Jul 1, 2021

Despite the open issues in this PR, I'm okay with getting it merged so that Gil look at some articles on staging. Ready when you are.

@smeijer smeijer marked this pull request as ready for review July 1, 2021 10:14
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid progress here 👍

@kentcdodds kentcdodds merged commit 5738172 into main Jul 1, 2021
@kentcdodds kentcdodds deleted the feature/blog-detail-page branch July 1, 2021 13:53
@kentcdodds kentcdodds mentioned this pull request Jul 1, 2021
@smeijer smeijer self-assigned this Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants