Add scrollbar color #300
Closed
Add scrollbar color #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added some screenshots too! |
|
Thanks for this! Could you provide a screenshot of what it looks like before these changes? I'm on a Mac so the scroll bar isn't visible unless I'm scrolling and it looks nice to me. What does it look like for you? |
|
Yeah sure! I've made the sceollbar thinner and removed it's background so it blends well |
|
Thank you for putting the time in for this. However I don't like the way this shifts the content of the page over to the left by the width of the scroll bar and I don't like that it looks worse on my own computer (a Mac). So I don't think I'll merge this change. Thanks anyway! |
|
Oh yeah sure! Makes sense. Thanks for taking the effort to try everything out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the website has the default scrollbar. It looks a little ugly (especially since the website looks so amazing!), so I added some colours that align with the theme there.
Note: this only shows on webkit browsers