Support react 18 #167
Support react 18 #167
Conversation
Just a test to confirm that node 16 can run the tests properly
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 280 280
Branches 1 1
=========================================
Hits 280 280
Continue to review full report at Codecov.
|
|
Here's a question. With GH actions can we setup a matrix to run against multiple React versions? |
| @@ -16,7 +16,7 @@ jobs: | |||
| if: ${{ !contains(github.head_ref, 'all-contributors') }} | |||
| strategy: | |||
| matrix: | |||
| node: [12, 14] | |||
| node: [12, 14, 16] | |||
There was a problem hiding this comment.
Tests now pass on Node 16 🎉
| @@ -195,7 +195,7 @@ import Demo from './demo.blah' | |||
|
|
|||
| assert.match( | |||
| error.message, | |||
| `error: [plugin: inMemory] Invalid loader: "blah" (valid: js, jsx, ts, tsx, css, json, text, base64, dataurl, file, binary)`, | |||
| `ERROR: [plugin: inMemory] Invalid loader value: "blah"`, | |||
There was a problem hiding this comment.
I figuered since esbuild might add other loaders by default so we don't want this test to fail when that happens.
Yes, it's possible. No, it's not worth it 😅 |
|
Oh, and I would be quite surprised if this broke React 17 🤔 |
|
🎉 This PR is included in version 8.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
After updating to React 18 the path to the jsx-runtime has changed which means we needto update the import in mdx-bundler.
Its as simple as dropping the
.jsfrom the import.I've also updated the tests to be compatible with the new errors from esbuild.
This might technically be a breaking change as it will probabbly break react 17.