Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/fix importing mdx from node modules #46

Conversation

gaelhameon
Copy link
Contributor

What: return undefined instead of {} when inMemoryPlugin doesn't handle the file, to actually let esbuild (or other plugins) handle the file. Solves #41

Why: the esbuild doc is kind of confusing, but empirical evidence suggests that returning {} doesn't allow other plugins or esbuild itself to try and resolve/load the file

How: replace {} by undefined where necessary

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged

@Arcath
Copy link
Collaborator

Arcath commented May 2, 2021

Thanks for the PR!

I've implemented this change in #45 along with some other improvements for #41. I didn't see that you where going to opena PR until I'd already done the work.

I added you as a co-author on the first commit as the issues with resolution where solved using your suggestions in #41 before I moved the compiling into its own esbuild plugin.

@Arcath
Copy link
Collaborator

Arcath commented May 10, 2021

This has been fixed by #45

@Arcath Arcath closed this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants