Pr/fix importing mdx from node modules #46
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: return
undefined
instead of{}
when inMemoryPlugin doesn't handle the file, to actually let esbuild (or other plugins) handle the file. Solves #41Why: the esbuild doc is kind of confusing, but empirical evidence suggests that returning
{}
doesn't allow other plugins or esbuild itself to try and resolve/load the fileHow: replace
{}
byundefined
where necessaryChecklist: