Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

adapt to angular app running inside iframe #25

Merged
merged 1 commit into from
Apr 2, 2015

Conversation

jinyangzhen
Copy link

A simple change to allow ng-stat snippet to monitor watches from angular app running inside iframe, for example Plunker and JSFiddle.

@kentcdodds
Copy link
Owner

Awesome! Could you give me a way that I can test this out myself? I'm not sure that I know exactly how to test this.

@jinyangzhen
Copy link
Author

ng-stat

As attached screen shot

  1. Launch a plunker case in Chrome
  2. Open DevTool, and in console tab, switch to the iframe 'PlunkerPreviewTarget'
  3. Add/Run ng-stat.js snippet in source tab
  4. the monitoring chart will be displayed in result frame, indicates ng-stat is now set to monitoring the plunker case instead of plunker itself :-)

@kentcdodds
Copy link
Owner

Ah! I didn't know you could do that! Cool! Give me some more time to look
at this and then I think this will definitely make it in! Thanks for
showing me that neat trick too!

-Kent C. Dodds

On Wed, Apr 1, 2015 at 10:43 PM, Yangzhen Jin notifications@github.com
wrote:

[image: ng-stat]
https://cloud.githubusercontent.com/assets/1779918/6957836/c4ffeb88-d934-11e4-9357-f9b295941dbb.png

As attached screen shot

  1. Launch a plunker case in Chrome
  2. Open DevTool, and in console tab, switch to the iframe
    'PlunkerPreviewTarget'
  3. Add/Run ng-stat.js snippet in source tab
  4. the monitoring chart will be displayed in result frame, indicates
    ng-stat is now set to monitoring the plunker case instead of plunker itself
    :-)


Reply to this email directly or view it on GitHub
#25 (comment).

@kentcdodds
Copy link
Owner

Looks good to me! Thanks!

kentcdodds pushed a commit that referenced this pull request Apr 2, 2015
adapt to angular app running inside iframe
@kentcdodds kentcdodds merged commit 3b357c6 into kentcdodds:master Apr 2, 2015
@kentcdodds
Copy link
Owner

Published as 2.2.0. Thanks!

@Jag-MW
Copy link

Jag-MW commented Feb 22, 2017

Hi, is there a way we can just use the api in the protractor tests to get the values of digest length?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants