Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Blog posts are in wrong order (#563) #564

Merged
merged 1 commit into from Oct 2, 2020
Merged

fix: Blog posts are in wrong order (#563) #564

merged 1 commit into from Oct 2, 2020

Conversation

onemen
Copy link
Contributor

@onemen onemen commented Oct 2, 2020

fix: #563

It look like the change in match-sorter pr still sort when search value is absent #101 was a breaking change.

Would you consider reverting the change and put it behind an options flag?

kentcdodds
kentcdodds approved these changes Oct 2, 2020
View reviewed changes
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 233e2b7 into kentcdodds:master Oct 2, 2020
@kentcdodds
Copy link
Owner

@all-contributors please add @onemen for code

@allcontributors allcontributors bot mentioned this pull request Oct 2, 2020
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @onemen! 🎉

@onemen onemen deleted the fix_563 branch October 2, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blog posts are in wrong order
2 participants
@onemen @kentcdodds