add JSDoc to typings of exported functions #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
* Allow for running in node environment * use jest projects * remove unecessary code and add coverage checking * fix coverage * time is funny
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
This fixes code coverage of testing-library#125 by extracting helper functions. There are still few istanbul ignores in code but they are not mine :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add JSDoc to typings of exported functions (see #123).
Why:
Better experience for developers using the type annotations in their IDE like VS Code.
How:
Annotate typings/index.d.ts.
Checklist: