Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides don't work the same with test-data-bot as previous extra credit #88

Closed
fitzage opened this issue Jun 8, 2022 · 1 comment
Closed

Comments

@fitzage
Copy link

fitzage commented Jun 8, 2022

In exercise 4 extra credit 3, we allowed overrides for our object factory.

In extra credit 4, no mention is made of the fact that the overrides have to be passed differently. The video makes it sound like you can just do it in the same way, but that doesn't work.

In extra credit 3, we can call buildLoginForm({username: 'chucknorris'}), but in extra credit 4 it needs to be buildLoginForm({overrides: {username: 'test'}}).

This threw me for a loop until I looked back at the docs for test-data-bot. I feel like this should have been called out somewhere.

@kentcdodds
Copy link
Owner

Good point! Would you be willing to add a note to the markdown file to help people know about the change?

fitzage added a commit to fitzage/testing-react-apps that referenced this issue Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants