Add an Update method to update an existing tag #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2905847624Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
The detected lint issue is incorrect. The |
vincentbernat
force-pushed
the
feature/update-tag
branch
from
6efe903
to
18ace47
Compare
|
My bad, I always thought Go would panic when looking up a non-existing key. That's not true! |
|
I'll update the PR shortly with an updated and more generic approach. |
vincentbernat
commented
Aug 25, 2022
template/tree_v4.go
Outdated
| if t.nodes[nodeIndex].TagCount == 0 { | ||
| t.nodes[nodeIndex].TagCount = 1 | ||
| } else { | ||
| ret = false | ||
| } | ||
| t.tags[(uint64(nodeIndex) << 32)] = tag | ||
| t.tags[(uint64(nodeIndex) << 32)] = updateFunc(t.tags[(uint64(nodeIndex) << 32)]) |
There was a problem hiding this comment.
This part is incorrect as the existing tag could be random when TagCount was 0. That's one reason I need to work a bit more on this PR.
This is useful to avoid a double lookup: once to find the current value, the second time to update its value. The tag could be a counter we want to update or, with the generics tree, any struct/map. `SetOrUpdate()` is the same as `Set()`, but when there already is a tag, it is passed to the provided update function instead of being replaced by the provided tag value. If no match, the provided tag value is used instead. `AddOrUpdate()` is the same as `Add()` and works like `Set()` except it will append a tag (when no match) or modify the first matching tag (when there is a match). Both functions take a tag value which is used when the existing tag does not exist (no tag for `SetOrUpdate()` or no matching tag for `AddOrUpdate()`). Both functions take an update function which is used when there is an existing tag and the update function is applied on the existing tag to get another tag. The provided tag is therefore ignored in this case.
vincentbernat
force-pushed
the
feature/update-tag
branch
from
18ace47
to
8115a48
Compare
|
Here is the second tentative. The differences:
The |
aaronfuj
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to avoid a double lookup: once to find the current
value, the second time to update its value. The tag could be a counter
we want to update or, with the generics tree, any struct/map.
The code change is minimal but
Set()could be a bit smaller since itreuses the same code path. However, I believe the compiler should be
smart enough to turn the constant function into a single value.