Add Delete*() methods to iterator
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to remove tags matching a certain criteria in the whole tree. For example, when implementing a RIB, we may want to remove tags associated with a down peer. The tree compaction is extracted into its own function and returns an hint on how compaction was done. This hint is then used by the `Delete*()` functions to update the current iterator.
Pull Request Test Coverage Report for Build 3098829968Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
This is an old PR but I would find it very handy for our purposes as well. Please consider merging it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to remove tags matching a certain criteria in the whole tree. For example, when implementing a RIB, we may want to remove tags associated with a down peer.
The tree compaction is extracted into its own function and returns an hint on how compaction was done. This hint is then used by the
Delete*()functions to update the current iterator.