Stop recommending ConfigDumper and instead, recommend its removal

kentnl · Sep 10, 2016 · 56ba202 · 56ba202
1 parent 5334677
commit 56ba202
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -1,6 +1,9 @@
 Release history for Dist-Zilla-Plugin-Author-KENTNL-RecommendFixes
 
 {{$NEXT}}
+ [Checks]
+ - Derecommend use of ConfigDumper, it was a nice idea, but the dependency and test complexity I can do without.
+
  [Dependencies::Stats]
  - Dependencies changed since 0.005001, see misc/*.deps* for details
  - develop: +2 ↑1 (suggests: ↑1)

diff --git a/lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm b/lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm
@@ -492,7 +492,7 @@ sub dzil_plugin_check {
   my (@plugins) = grep { $_->stringify =~ /\Alib\/Dist\/Zilla\/Plugin\//msx } @{ $self->libfiles };
   return unless @plugins;
   for my $plugin (@plugins) {
-    $assert->should( have_line => $plugin, _plugin_re('Dist+Zilla+Util+ConfigDumper') );
+    $assert->should_not( have_line => $plugin, _plugin_re('Dist+Zilla+Util+ConfigDumper') );
   }
   return unless $self->tdir;
   return unless @{ $self->tfiles };