Build results of c7b770e (on master)

kentnl · Sep 25, 2014 · b55da7b · b55da7b
1 parent 2be37aa
commit b55da7b
Show file tree

Hide file tree

Showing 12 changed files with 83 additions and 46 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,13 @@
 Release history for Dist-Zilla-Plugin-Author-KENTNL-RecommendFixes
 
+0.003005 2014-09-25T16:09:00Z
+ [Dependencies::Stats]
+ - Dependencies changed since 0.003004, see misc/*.deps* for details
+ - develop: (suggests: ↑1)
+
+ [Internals]
+ - Prototype the input_transform feature discussed.
+
 0.003004 2014-09-22T19:06:39Z
  [Checks]
  - Warn about bad hashtags.

diff --git a/META.json b/META.json
@@ -77,7 +77,7 @@
          },
          "suggests" : {
             "Dist::Zilla::App::Command::bakeini" : "0.001002",
-            "Dist::Zilla::PluginBundle::Author::KENTNL" : "2.020001"
+            "Dist::Zilla::PluginBundle::Author::KENTNL" : "2.020003"
          }
       },
       "runtime" : {
@@ -115,7 +115,7 @@
    "provides" : {
       "Dist::Zilla::Plugin::Author::KENTNL::RecommendFixes" : {
          "file" : "lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm",
-         "version" : "0.003004"
+         "version" : "0.003005"
       }
    },
    "release_status" : "stable",
@@ -130,14 +130,14 @@
          "web" : "https://github.com/kentnl/Dist-Zilla-Plugin-Author-KENTNL-RecommendFixes"
       }
    },
-   "version" : "0.003004",
+   "version" : "0.003005",
    "x_BuiltWith" : {
       "modules" : {
          "CPAN::Meta" : "2.142060",
          "Carp" : "1.34",
          "Data::DPath" : "0.50",
          "Dist::Zilla::App::Command::bakeini" : "0.001002",
-         "Dist::Zilla::Plugin::Author::KENTNL::RecommendFixes" : "0.003005",
+         "Dist::Zilla::Plugin::Author::KENTNL::RecommendFixes" : "0.003006",
          "Dist::Zilla::Plugin::Authority" : "1.006",
          "Dist::Zilla::Plugin::AutoPrereqs" : "5.020",
          "Dist::Zilla::Plugin::BumpVersionAfterRelease" : "0.002",
@@ -157,7 +157,7 @@
          "Dist::Zilla::Plugin::Manifest" : "5.020",
          "Dist::Zilla::Plugin::ManifestSkip" : "5.020",
          "Dist::Zilla::Plugin::MetaConfig" : "5.020",
-         "Dist::Zilla::Plugin::MetaData::BuiltWith" : "1.003000",
+         "Dist::Zilla::Plugin::MetaData::BuiltWith" : "1.003001",
          "Dist::Zilla::Plugin::MetaJSON" : "5.020",
          "Dist::Zilla::Plugin::MetaProvides::Package" : "2.001002",
          "Dist::Zilla::Plugin::MetaTests" : "5.020",
@@ -181,14 +181,14 @@
          "Dist::Zilla::Plugin::TestRelease" : "5.020",
          "Dist::Zilla::Plugin::Twitter" : "0.025",
          "Dist::Zilla::Plugin::UploadToCPAN" : "5.020",
-         "Dist::Zilla::PluginBundle::Author::KENTNL" : "2.020001",
+         "Dist::Zilla::PluginBundle::Author::KENTNL" : "2.020003",
          "Dist::Zilla::Role::InstallTool" : "5.020",
          "Dist::Zilla::Util::Test::KENTNL" : "1.003002",
          "ExtUtils::MakeMaker" : "6.98",
          "File::Spec" : "3.49",
          "MooX::Lsub" : "0.002000",
-         "Moose" : "2.1212",
-         "Path::Tiny" : "0.057",
+         "Moose" : "2.1213",
+         "Path::Tiny" : "0.058",
          "Pod::Coverage::TrustPod" : "0.100003",
          "Term::ANSIColor" : "4.03",
          "Test::CPAN::Changes" : "0.30",
@@ -292,7 +292,7 @@
                }
             },
             "name" : "@Author::KENTNL/MetaData::BuiltWith",
-            "version" : "1.003000"
+            "version" : "1.003001"
          },
          {
             "class" : "Dist::Zilla::Plugin::Git::Contributors",
@@ -568,7 +568,7 @@
          {
             "class" : "Dist::Zilla::Plugin::Author::KENTNL::RecommendFixes",
             "name" : "@Author::KENTNL/Author::KENTNL::RecommendFixes",
-            "version" : "0.003004"
+            "version" : "0.003005"
          },
          {
             "class" : "Dist::Zilla::Plugin::ReadmeFromPod",
@@ -655,7 +655,7 @@
                "Dist::Zilla::Plugin::Git::Tag" : {
                   "branch" : null,
                   "signed" : 0,
-                  "tag" : "0.003004-source",
+                  "tag" : "0.003005-source",
                   "tag_format" : "%v-source",
                   "tag_message" : "v%v",
                   "time_zone" : "local"
@@ -726,7 +726,7 @@
                "Dist::Zilla::Plugin::Git::Tag" : {
                   "branch" : "releases",
                   "signed" : 0,
-                  "tag" : "0.003004",
+                  "tag" : "0.003005",
                   "tag_format" : "%v",
                   "tag_message" : "v%v",
                   "time_zone" : "local"

diff --git a/META.yml b/META.yml
@@ -20,7 +20,7 @@ name: Dist-Zilla-Plugin-Author-KENTNL-RecommendFixes
 provides:
   Dist::Zilla::Plugin::Author::KENTNL::RecommendFixes:
     file: lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm
-    version: '0.003004'
+    version: '0.003005'
 requires:
   Carp: '0'
   Data::DPath: '0'
@@ -39,14 +39,14 @@ resources:
   bugtracker: https://github.com/kentnl/Dist-Zilla-Plugin-Author-KENTNL-RecommendFixes/issues
   homepage: https://github.com/kentnl/Dist-Zilla-Plugin-Author-KENTNL-RecommendFixes
   repository: https://github.com/kentnl/Dist-Zilla-Plugin-Author-KENTNL-RecommendFixes.git
-version: '0.003004'
+version: '0.003005'
 x_BuiltWith:
   modules:
     CPAN::Meta: '2.142060'
     Carp: '1.34'
     Data::DPath: '0.50'
     Dist::Zilla::App::Command::bakeini: '0.001002'
-    Dist::Zilla::Plugin::Author::KENTNL::RecommendFixes: '0.003005'
+    Dist::Zilla::Plugin::Author::KENTNL::RecommendFixes: '0.003006'
     Dist::Zilla::Plugin::Authority: '1.006'
     Dist::Zilla::Plugin::AutoPrereqs: '5.020'
     Dist::Zilla::Plugin::BumpVersionAfterRelease: '0.002'
@@ -66,7 +66,7 @@ x_BuiltWith:
     Dist::Zilla::Plugin::Manifest: '5.020'
     Dist::Zilla::Plugin::ManifestSkip: '5.020'
     Dist::Zilla::Plugin::MetaConfig: '5.020'
-    Dist::Zilla::Plugin::MetaData::BuiltWith: '1.003000'
+    Dist::Zilla::Plugin::MetaData::BuiltWith: '1.003001'
     Dist::Zilla::Plugin::MetaJSON: '5.020'
     Dist::Zilla::Plugin::MetaProvides::Package: '2.001002'
     Dist::Zilla::Plugin::MetaTests: '5.020'
@@ -90,14 +90,14 @@ x_BuiltWith:
     Dist::Zilla::Plugin::TestRelease: '5.020'
     Dist::Zilla::Plugin::Twitter: '0.025'
     Dist::Zilla::Plugin::UploadToCPAN: '5.020'
-    Dist::Zilla::PluginBundle::Author::KENTNL: '2.020001'
+    Dist::Zilla::PluginBundle::Author::KENTNL: '2.020003'
     Dist::Zilla::Role::InstallTool: '5.020'
     Dist::Zilla::Util::Test::KENTNL: '1.003002'
     ExtUtils::MakeMaker: '6.98'
     File::Spec: '3.49'
     MooX::Lsub: '0.002000'
-    Moose: '2.1212'
-    Path::Tiny: '0.057'
+    Moose: '2.1213'
+    Path::Tiny: '0.058'
     Pod::Coverage::TrustPod: '0.100003'
     Term::ANSIColor: '4.03'
     Test::CPAN::Changes: '0.30'
@@ -180,7 +180,7 @@ x_Dist_Zilla:
               - -i
             uname_call: uname
       name: '@Author::KENTNL/MetaData::BuiltWith'
-      version: '1.003000'
+      version: '1.003001'
     -
       class: Dist::Zilla::Plugin::Git::Contributors
       config:
@@ -393,7 +393,7 @@ x_Dist_Zilla:
     -
       class: Dist::Zilla::Plugin::Author::KENTNL::RecommendFixes
       name: '@Author::KENTNL/Author::KENTNL::RecommendFixes'
-      version: '0.003004'
+      version: '0.003005'
     -
       class: Dist::Zilla::Plugin::ReadmeFromPod
       name: '@Author::KENTNL/ReadmeFromPod'
@@ -459,7 +459,7 @@ x_Dist_Zilla:
         Dist::Zilla::Plugin::Git::Tag:
           branch: ~
           signed: '0'
-          tag: 0.003004-source
+          tag: 0.003005-source
           tag_format: '%v-source'
           tag_message: v%v
           time_zone: local
@@ -513,7 +513,7 @@ x_Dist_Zilla:
         Dist::Zilla::Plugin::Git::Tag:
           branch: releases
           signed: '0'
-          tag: '0.003004'
+          tag: '0.003005'
           tag_format: '%v'
           tag_message: v%v
           time_zone: local

diff --git a/Makefile.PL b/Makefile.PL
@@ -40,7 +40,7 @@ my %WriteMakefileArgs = (
     "Test::DZil" => 0,
     "Test::More" => "0.89"
   },
-  "VERSION" => "0.003004",
+  "VERSION" => "0.003005",
   "test" => {
     "TESTS" => "t/*.t t/00-compile/*.t"
   }

diff --git a/README b/README
@@ -3,7 +3,7 @@ NAME
     changes to the dist.
 
 VERSION
-    version 0.003004
+    version 0.003005
 
 DESCRIPTION
     Nothing interesting to see here.

diff --git a/dist.ini b/dist.ini
@@ -78,7 +78,7 @@ replacer = replace_with_blank
 -phase = develop
 -type = suggests
 Dist::Zilla::App::Command::bakeini = 0.001000
-Dist::Zilla::PluginBundle::Author::KENTNL = 2.020001
+Dist::Zilla::PluginBundle::Author::KENTNL = 2.020003
 
 [MinimumPerl / @Author::KENTNL/MinimumPerl]
 

diff --git a/lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm b/lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm
@@ -5,7 +5,7 @@ use utf8;
 
 package Dist::Zilla::Plugin::Author::KENTNL::RecommendFixes;
 
-our $VERSION = '0.003004';
+our $VERSION = '0.003005';
 
 # ABSTRACT: Recommend generic changes to the dist.
 
@@ -99,15 +99,20 @@ sub _build__pc {
 
   my $get_lines = sub {
     my ($path) = @_;
-    return $line_cache->( $path => sub { [ path($path)->lines_raw( { chomp => 1 } ) ] } );
+    return $line_cache->( $path => sub { [ $path->lines_raw( { chomp => 1 } ) ] } );
   };
 
   return $self->_mk_assertions(
+    '-transform' => sub {
+      my ( undef, @bits ) = @_;
+      my $path = shift @bits;
+      return ( $self->_rel($path), @bits );
+    },
     exist => sub {
-      if ( path(@_)->exists ) {
-        return ( 1, "@_ exists" );
+      if ( $_[0]->exists ) {
+        return ( 1, "$_[0] exists" );
       }
-      return ( 0, "@_ does not exist" );
+      return ( 0, "$_[0] does not exist" );
     },
     have_line => sub {
       my ( $path, $regex ) = @_;
@@ -200,14 +205,14 @@ my %amap = (
 
 for my $key (qw( git libdir dist_ini )) {
   my $value = delete $amap{$key};
-  lsub $key => _badly { $_[0]->_pc->should( exist => $_[0]->_rel($value) ) };
+  lsub $key => _badly { $_[0]->_pc->should( exist => $value ) };
 }
 for my $key ( keys %amap ) {
   my $value = $amap{$key};
-  lsub $key => sub { $_[0]->_pc->should( exist => $_[0]->_rel($value) ) };
+  lsub $key => sub { $_[0]->_pc->should( exist => $value ) };
 }
 
-lsub tdir => sub { $_[0]->_pc->should( exist => $_[0]->_rel('t') ) };
+lsub tdir => sub { $_[0]->_pc->should( exist => 't' ) };
 
 lsub changes_deps_files => sub { return [qw( Changes.deps Changes.deps.all Changes.deps.dev Changes.deps.all )] };
 
@@ -249,8 +254,8 @@ sub has_new_changes_deps {
   my $ok     = 1;
   my $assert = $self->_pc;
   for my $file ( @{ $self->changes_deps_files } ) {
-    undef $ok unless $assert->should( exist => $self->_rel( 'misc', $file ) );
-    undef $ok unless $assert->should_not( exist => $self->_rel($file) );
+    undef $ok unless $assert->should( exist => 'misc/' . $file );
+    undef $ok unless $assert->should_not( exist => $file );
   }
   return $ok;
 }
@@ -259,8 +264,8 @@ sub has_new_perlcritic_deps {
   my ($self) = @_;
   my $ok     = 1;
   my $assert = $self->_pc;
-  undef $ok unless $assert->should( exist => $self->_rel( 'misc', 'perlcritic.deps' ) );
-  undef $ok unless $assert->should_not( exist => $self->_rel('perlcritic.deps') );
+  undef $ok unless $assert->should( exist => 'misc/perlcritic.deps' );
+  undef $ok unless $assert->should_not( exist => 'perlcritic.deps' );
   return $ok;
 }
 
@@ -471,6 +476,17 @@ no Moose;
     return bless $arg_hash, $class;
   }
 
+  sub _input_transform {
+    my ($self) = @_;
+    return $self->{'-transform'} if exists $self->{'-transform'};
+    return ( $self->{'-transform'} = sub { shift; return @_ } );
+  }
+
+  sub input_transform {
+    my ( $self, $name, @input ) = @_;
+    return $self->_input_transform->( $name, @input );
+  }
+
   sub _handler_defaults {
     return {
       test => sub {
@@ -511,8 +527,9 @@ no Moose;
       if ( not exists $self->{'-tests'}->{$name} ) {
         croak sprintf q[INVALID ASSERTION %s ( avail: %s )], $name, ( join q[,], keys %{ $self->{'-tests'} } );
       }
-      my ( $status, $message ) = $self->{'-tests'}->{$name}->(@slurpy);
-      return $self->{'-handlers'}->{$handler}->( $status, $message, $name, @slurpy );
+      my (@input) = $self->input_transform( $name, @slurpy );
+      my ( $status, $message ) = $self->{'-tests'}->{$name}->(@input);
+      return $self->{'-handlers'}->{$handler}->( $status, $message, $name, @input );
     };
     {
       ## no critic (TestingAndDebugging::ProhibitNoStrict])
@@ -536,7 +553,7 @@ Dist::Zilla::Plugin::Author::KENTNL::RecommendFixes - Recommend generic changes
 
 =head1 VERSION
 
-version 0.003004
+version 0.003005
 
 =head1 DESCRIPTION
 

diff --git a/misc/Changes.deps b/misc/Changes.deps
@@ -1,6 +1,8 @@
 This file contains changes in REQUIRED dependencies for standard CPAN phases (configure/build/runtime/test)
 
-0.003004
+0.003005
+
+0.003004 2014-09-22T19:06:39Z
  [Added / runtime requires]
  - constant
 

diff --git a/misc/Changes.deps.all b/misc/Changes.deps.all
@@ -1,6 +1,10 @@
 This file contains ALL changes in dependencies in both REQUIRED / OPTIONAL dependencies for all phases (configure/build/runtime/test/develop)
 
-0.003004
+0.003005
+ [Changed / develop suggests]
+ - Dist::Zilla::PluginBundle::Author::KENTNL 2.020001 → 2.020003
+
+0.003004 2014-09-22T19:06:39Z
  [Added / runtime requires]
  - constant
 

diff --git a/misc/Changes.deps.dev b/misc/Changes.deps.dev
@@ -1,6 +1,10 @@
 This file contains changes to DEVELOPMENT dependencies only ( both REQUIRED and OPTIONAL )
 
-0.003004
+0.003005
+ [Changed / develop suggests]
+ - Dist::Zilla::PluginBundle::Author::KENTNL 2.020001 → 2.020003
+
+0.003004 2014-09-22T19:06:39Z
 
 0.003003 2014-09-21T12:42:45Z
  [Changed / develop suggests]

diff --git a/misc/Changes.deps.opt b/misc/Changes.deps.opt
@@ -1,6 +1,8 @@
 This file contains changes in OPTIONAL dependencies for standard CPAN phases (configure/build/runtime/test)
 
-0.003004
+0.003005
+
+0.003004 2014-09-22T19:06:39Z
 
 0.003003 2014-09-21T12:42:45Z
 

diff --git a/t/00-report-prereqs.dd b/t/00-report-prereqs.dd
@@ -62,7 +62,7 @@ do { my $x = {
                                     },
                       'suggests' => {
                                       'Dist::Zilla::App::Command::bakeini' => '0.001002',
-                                      'Dist::Zilla::PluginBundle::Author::KENTNL' => '2.020001'
+                                      'Dist::Zilla::PluginBundle::Author::KENTNL' => '2.020003'
                                     }
                     },
        'runtime' => {