warn (don't die) on uname errors
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change fatal exception to warning and return of empty results for _uname() .# Discussion Local versions of `uname` may not support all options, which will cause errors upon invocation. Previously, this killed the build. Now, the error output of `uname` will be printed (by `uname`), followed by a warning entered into the build log. But the build will continue. This allows builds on systems with oulder `uname` versions.
rivy
force-pushed
the
fix/skip.uname.errors
branch
from
a415b26
to
3bfef75
Compare
|
I amended the commit to fix the test failure. I missed seeing the actual Perl::Critic error within the flurry of '"Policy "Perl::Critic::Policy::..." is not installed.' messages. |
|
Its probably worth noting that that's the only place _my_log_fatal is called in this module, and I must have added that function for a reason. The trick is trying to remember why :) |
|
Ok, yeah. Capturing the error output and streaming that to the log is probably helpful, I guess. As to why the existing code does what it does, gonna chalk it up to "being young and stupid" 😉 |
kentfredric
added a commit
that referenced
this pull request
Sep 10, 2016
kentfredric
added a commit
that referenced
this pull request
Sep 10, 2016
[Bugfix] - Don't die when uname call fails. - To be honest, I'm still not sure why I was doing this in the first place. - Patch Patched (with thanks) by Roy Ivy II ( #1 ) [Dependencies::Stats] - Dependencies changed since 1.004003, see misc/*.deps* for details - develop: (suggests: ↑1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.# Discussion
Local versions of
unamemay not support all options, which will cause errors uponinvocation. Previously, this killed the build. Now, the error output of
unamewillbe printed (by
uname), followed by a warning entered into the build log. But thebuild will continue. This allows builds on systems with oulder
unameversions.This was unnecessarily tripping up builds on my machine with an older version of
uname. I didn't want to make a wholesale change, but it might be better to Capture::Tiny all the output and log theunameerror output. If you're interested, I can refactor for that outcome.