Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slickGoTo scrolls slides differently then when sliding one by one #148

Closed
burgalon opened this issue Apr 16, 2014 · 3 comments
Closed

slickGoTo scrolls slides differently then when sliding one by one #148

burgalon opened this issue Apr 16, 2014 · 3 comments

Comments

@burgalon
Copy link
Contributor

When using slickGoTo(x) and slidesToShow= 3, the carousel scrolls to show only 1 slide leaving 2 slots empty. e.g:

[1 2 3] 4 -----slickGoTo(4) ---> 1 2 3 [4 _ _ ]
instead of
[1 2 3] 4 -----slickGoTo(4) ---> 1 [ 2 3 4 ]

See example on GiraffeList - Scroll the top carousel to the rightmost item. This will cause the lower carousel to call slickGoTo(..)

@kenwheeler
Copy link
Owner

Are you using the most recent version?

@kenwheeler
Copy link
Owner

@burgalon did the update fix this for you?

@burgalon
Copy link
Contributor Author

@kenwheeler New version resolves this issue
It seems like there were some API changes with onBeforeChange. Instead of passing animSlide it is now passing _.currentSlide. Can we add animSlide as a third parameter?

        if (_.options.onBeforeChange !== null && index !== _.currentSlide) {
            _.options.onBeforeChange.call(this, _, animSlide);
        }

kenwheeler added a commit that referenced this issue Apr 17, 2014
add animSlide as an argument to onBeforeChange call. Fixes #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants