Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globs in the bower.json main array are not supported #1529

Closed
wants to merge 1 commit into from
Closed

Globs in the bower.json main array are not supported #1529

wants to merge 1 commit into from

Conversation

philBrown
Copy link

@rockstardev
Copy link

@kenwheeler Can you please merge this to help solve the issue with bower-installer.

Here is Stackoverflow thread with more info:
http://stackoverflow.com/questions/31351375/how-to-change-bower-installer-path-for-one-component

@simeydotme
Copy link
Collaborator

I won't merge this yet, as the resource you've linked from Bower states no Font/Image files as main .. if you can clean up the PR to accomodate this, I will merge :)

@rockstardev
Copy link

@simeydotme On my machine there is no fonts/images - there is only 1 extra file, namely slick/ajax-loader.gif. So, from what I understand main in bower.json should be:

"main": [
    "slick/slick.min.js",
    "slick/slick.css",
    "slick/slick-theme.css",
    "slick/ajax-loader.gif",
    "slick/fonts/slick.eot",
    "slick/fonts/slick.svg",
    "slick/fonts/slick.ttf",
    "slick/fonts/slick.woff"
]

Correct?

@simeydotme
Copy link
Collaborator

from www.bower.io:

Image and font files may be used or referenced within the JS or Sass files, but are not main files as they are not entry-points.

  • Use source files with module exports and imports over pre-built distribution files.
  • Do not include minified files.
  • Do not include assets files like images, fonts, audio, or video.
  • Filenames should not be versioned (Bad: package.1.1.0.js; Good: package.js).
  • Globs like js/*.js are not allowed.

Currently the highlighted parts are wrong, there's no point me accepting a PR which doesn't fix the thing completely :D -- if you can fix the PR to cover all those points, I will merge, else give me some time to do it myself.

Si.

@leevigraham
Copy link

For future reference: bower/spec#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants