Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming conventions #12

Open
memeplex opened this issue Apr 23, 2017 · 5 comments
Open

Naming conventions #12

memeplex opened this issue Apr 23, 2017 · 5 comments
Labels
for newcomers

Comments

@memeplex
Copy link

Not that this is all too important, but given that in a (lesser) sense yours is also a python programming showcase, wouldn't it be desirable to honour pep8 suggestions? For example, to avoid camel case names like isEmpty.
@keon
Copy link
Owner

keon commented Apr 23, 2017

Yeah, PEP8 is good and I think it is important.
The current implementation has mixed styles, which I think is confusing.
I just didn't have time to organize them. I think I'll do so in a month.

@parth-verma
Copy link

Hi, I'd like to take this up.

@muneeb20
Copy link

#242

@herinckc herinckc mentioned this issue Jun 8, 2018
Merged
8 tasks
@feygon
Copy link
Contributor

feygon commented Aug 15, 2018 •
edited

Since this issue is still open, I'd like to take this up and make another PEP8 style review.
(also noting #242)

@feygon feygon mentioned this issue Aug 15, 2018
Merged
@ruijpbastos
Copy link

Have the issues been solved with the two merged PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@memeplex @muneeb20 @keon @feygon @ruijpbastos @parth-verma @goswami-rahul