Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate test module #162

Closed
goswami-rahul opened this issue Mar 26, 2018 · 11 comments
Closed

separate test module #162

goswami-rahul opened this issue Mar 26, 2018 · 11 comments

Comments

@goswami-rahul
Copy link
Collaborator

Since we now have tests in most of the algorithms, I think it is a good idea to have a separate test_module.py file in each module. We can move all the tests from one module to it, and any further algorithms must have their tests in this file. It will make the repo easy to manage.
@keon what do you think? I can start working on this.

@christianbender
Copy link
Collaborator

@goswami-rahul
The problem is that we have not in all projects unit tests. Many projects (that I have see) have simple tests with the print function that prints something on the console. The idea with the central test-file sounds good.

@goswami-rahul
Copy link
Collaborator Author

yeah those print statements need to be changed to tests too.
But there is one disadvantage in moving tests to separate file, that the tests at the same place can also help viewers understand the algorithms better.

@christianbender
Copy link
Collaborator

@goswami-rahul I will jump in.

@christianbender
Copy link
Collaborator

@goswami-rahul @keon
I will test the module maths. I add a file test_module.py with all tests.

@goswami-rahul
Copy link
Collaborator Author

@christianbender I would wait for starting work on this until @keon approves on this issue.

@christianbender
Copy link
Collaborator

@goswami-rahul OK, I will wait. Thanks for the notice

@danghai
Copy link
Collaborator

danghai commented Apr 7, 2018

@goswami-rahul pings me when you need my help for this issue

@christianbender
Copy link
Collaborator

@danghai At the moment I pause on my work on this task. Because we don't have an approval.

@keon
Copy link
Owner

keon commented Apr 10, 2018

@christianbender

sorry for the late reply :(
As the repo gets larger, separating test code may be more scalable.
Let's give it a shot and see if it works better!

@christianbender
Copy link
Collaborator

@keon @goswami-rahul #220

@danghai
Copy link
Collaborator

danghai commented Apr 23, 2018

Relate to #254 #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants