Small mistake in sort/merge_sort.py array merge

[fooofei]

code location: keon/algorithms/blob/master/sort/merge_sort.py

mistake 1

origion code: line - 30

    # Add the left overs if there's any left to the result
    if left:
        arr.extend(left[left_cursor:])
    if right:
        arr.extend(right[right_cursor:])
    return arr

should be ==>

    # Add the left overs if there's any left to the result
    if left_cursor < len(left)::
        arr.extend(left[left_cursor:])
    if right_cursor < len(right)::
        arr.extend(right[right_cursor:])
    return arr

more pythonic efficient way ,no construct sub array ==>

    # Add the left overs if there's any left to the result
    for i in range(left_cursor,len(left)):
        arr.append(left[i])
    for i in range(right_cursor,len(right)):
        arr.append(right[i])
    return arr

mistake 2

origion code : line - 38

print(merge_sort(array, 0, len(array)-1))
print(array)

should be ==>

print(merge_sort(array))

[alisha17]

Can I work on this issue?

[keon]

@alisha17 of course!

[ankit167]

@alisha17 'arr' needs to be returned at the end of the merge() (in the new code)

[fooofei]

@ankit167 thanks for point that return arr