Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add metadata to hdf5 files. #39

Closed
allgenesconsidered opened this issue May 9, 2018 · 1 comment
Closed

Suggestion: Add metadata to hdf5 files. #39

allgenesconsidered opened this issue May 9, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@allgenesconsidered
Copy link
Collaborator

I've noticed how some ExcisionFinder functions repeat arguments, such as locus information, Cas enzymes, guide lengths, etc. I wonder if it would be worth it to try and save that metadata to the annotation hdf5 file, so users won't need to retype arguments between scripts.

We could also allow users to override previous metadata if for example they ran annot_variants on several cas enzymes but only wanted to output guides for a select few. Also, adding metadata would allow users to better recall the parameter ran to produce their data in case they need to come back to it at a later time.

One way to implement this would be here:
https://stackoverflow.com/questions/29129095/save-additional-attributes-in-pandas-dataframe/29130146#29130146

@keoughkath
Copy link
Owner

Addressed with latest pull merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants