Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopgap fix for opus icons on newer MC #59

Open
wants to merge 1 commit into
base: develop-1.8
Choose a base branch
from

Conversation

Merith-TK
Copy link

Opus Utils.getVersion results in returning 1.1 rather than anything newer when on the 1.100.x CC versions (fabric and forge)

this is an stop gap fix, and yes, If I knew how I would tweak the matchers to make it work, but I dont so this will do, because whoever is on CC 1.1... needs to get off it,

@Kan18
Copy link
Contributor

Kan18 commented Jul 4, 2022

I think this might break again when CC:T 1.110.0 is released, here are some other ideas I had:

@Merith-TK
Copy link
Author

well, as the commit says, and the file comments I put in, this is an stopgap, not pretty, and definitely could use improvement, but it gets the job done without being too invasive on the code

@Merith-TK
Copy link
Author

so... any ideas for an better implementation of an fix?

@Kan18
Copy link
Contributor

Kan18 commented Dec 27, 2022

I think Anavrins mentioned at one point that returning multiple values could be a good implementation. I can try working on that (this is somewhat urgent now, since SwitchCraft 2 is literally going away in 12 minutes, and the new version will be on SC3 so more people will run into this bug; if anybody who isn't currently online is seeing this comment right now, please join!)

@Kan18 Kan18 mentioned this pull request Dec 28, 2022
@Merith-TK
Copy link
Author

With the release of SC3 this fix would be very much needed so icons can actually render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants