[bug]: Fixed range slider null selection bug (#1413)

Signed-off-by: Giuseppe Macri <macri.giuseppe@gmail.com> Co-authored-by: Giuseppe Macrì <macri.giuseppe@gmail.com>
keplergl · Mar 21, 2021 · 173811a · 173811a
1 parent df3fee5
commit 173811a
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/components/common/range-brush.js b/src/components/common/range-brush.js
@@ -95,16 +95,22 @@ function RangeBrushFactory() {
             return;
           }
           if (event.selection) {
+            this._lastSel = event.selection;
             this.brushing = true;
             this._brushed(event);
           }
         })
         .on('end', event => {
-          if (!this.brushing && this._startSel && !event.selection) {
-            // handle click
-
-            this._click(this._startSel);
+          if (!event.selection) {
+            if (this.brushing) {
+              // handle null selection
+              this._click(this._lastSel);
+            } else if (this._startSel) {
+              // handle click
+              this._click(this._startSel);
+            }
           }
+
           if (typeof this.props.onBrushEnd === 'function') this.props.onBrushEnd();
 
           this.brushing = false;