Add additional publish step for publishing kepler-jupyter to NPM

keplergl · Aug 20, 2021 · 46e84f3 · 46e84f3
1 parent f438ccd
commit 46e84f3
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/.github/workflows/build-publish-pypi.yml b/.github/workflows/build-publish-pypi.yml
@@ -53,11 +53,25 @@ jobs:
           name: keplergl-pypi
           path: bindings/kepler.gl-jupyter/dist/
 
-      - name: Publish Pypi
-        if: github.event_name == 'release' && github.event.action == 'created'
+      - name: Check Release Tag
+        id: check-tag
+        run: |
+          if [[ ${{ github.event.ref }} =~ ^refs/tags/v[0-9]+\.[0-9]+\.[0-9]+-jupyter$ ]]; then
+              echo ::set-output name=publish::true
+          fi
+      
+      - name: Publish KeplerGL to Pypi
+        if: steps.check-tag.outputs.publish == 'true'
         env:
           TWINE_USERNAME: __token__
-          TWINE_PASSWORD: ${{ secrets.npm_token }}
+          TWINE_PASSWORD: ${{ secrets.pypi_token }}
         run: |
           python -m twine upload bindings/kepler.gl-jupyter/dist/*.tar.gz 
-    
+
+      - name: Publish kepler-jupyter to NPM 
+        if: steps.check-tag.outputs.publish == 'true'
+        env:
+          NODE_AUTH_TOKEN: ${{secrets.npm_token}}
+        run: |
+          cd bindings/kepler.gl-jupyter/js
+          npm publish
diff --git a/bindings/kepler.gl-jupyter/README.md b/bindings/kepler.gl-jupyter/README.md
@@ -290,7 +290,7 @@ The output of the jupyter labextension is defined in the file `js/package.json`:
 
 Then, you can either install this labextension to test it:
 ```shell
-jupyter labextension install @jupyter-widgets/jupyterlab-manager keplergl-jupyter
+jupyter labextension install .
 ```
 or, you can manually create a symbolic link for the folder `bindings/kepler.gl-jupyter/kepler-jupyter/labextension` under the jupyter's folder `labextensions`, e.g. `/Users/test/opt/anaconda3/envs/test37/share/jupyter/labextensions`. You will need to reload the jupyter lab page.