[Enhancement] added check for oldLayerData (#1357)

Signed-off-by: Shan He <heshan0131@gmail.com>
keplergl · Dec 7, 2020 · 55f74dc · 55f74dc
1 parent 223af2b
commit 55f74dc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/layers/base-layer.js b/src/layers/base-layer.js
@@ -884,7 +884,8 @@ export default class Layer {
     }
 
     let data = [];
-    if (!triggerChanged.getData) {
+
+    if (!triggerChanged.getData && oldLayerData && oldLayerData.data) {
       // same data
       data = oldLayerData.data;
     } else {

diff --git a/src/layers/layer-text-label.js b/src/layers/layer-text-label.js
@@ -70,7 +70,12 @@ export const formatTextLabelData = ({textLabel, triggerChanged, oldLayerData, da
     const getText = textLabelAccessor(tl);
     let characterSet;
 
-    if (!triggerChanged[`getLabelCharacterSet-${i}`]) {
+    if (
+      !triggerChanged[`getLabelCharacterSet-${i}`] &&
+      oldLayerData &&
+      oldLayerData.textLabels &&
+      oldLayerData.textLabels[i]
+    ) {
       characterSet = oldLayerData.textLabels[i].characterSet;
     } else {
       const allLabels = tl.field ? data.map(getText) : [];