Skip to content

Commit

Permalink
[Chore] Upgrade to Node 14 (#2257)
Browse files Browse the repository at this point in the history
  • Loading branch information
igorDykhta committed Jun 20, 2023
1 parent 23763f0 commit 8312d06
Show file tree
Hide file tree
Showing 23 changed files with 163 additions and 1,552 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/npmpublish.yml
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v2.1.1
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14
registry-url: https://registry.npmjs.org/
- run: npm install -g yarn
- run: yarn
Expand Down
15 changes: 7 additions & 8 deletions .github/workflows/test.yml
Expand Up @@ -5,24 +5,23 @@ name: Node.js CI

on:
push:
branches: [ master ]
branches: [master]
pull_request:
branches: [ master ]
branches: [master]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [12.x]
node-version: [14.x]

steps:
- uses: actions/checkout@v2.1.1

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -33,10 +32,10 @@ jobs:
run: npm install -g yarn

- name: Install Dependecies
run: yarn
run: yarn global add "puppeteer@19.11.1" && yarn

- name: Lint
run: yarn lint
# - name: Lint
# run: yarn lint

- name: Test
run: xvfb-run --auto-servernum yarn cover
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
@@ -1 +1 @@
12.22.0
14.21.1
9 changes: 6 additions & 3 deletions contributing/DEVELOPERS.md
Expand Up @@ -22,7 +22,7 @@ machine:

* [Git](http://git-scm.com/): The [Github Guide to Installing Git][git-setup] is a good source of information.

* [Node.js ^6.x](http://nodejs.org): We use Node to generate the documentation, run a
* [Node.js ^14.x](http://nodejs.org): We use Node to generate the documentation, run a
development web server, run tests, and generate distributable files. Depending on your system,
you can install Node either from source or as a pre-packaged bundle.

Expand Down Expand Up @@ -52,14 +52,17 @@ cd kepler.gl
# Add the main kepler.gl repository as an upstream remote to your repository:
git remote add upstream "git@github.com:keplergl/kepler.gl.git"

# Install Puppeteer
yarn global add puppeteer

# Install JavaScript dependencies:
yarn
yarn bootstrap

# Setup mapbox access token locally
export MapboxAccessToken=<insert_your_token>

# Start the kepler.gl demo app
npm start
yarn start
```

An demo app will be served at
Expand Down
13 changes: 5 additions & 8 deletions package.json
Expand Up @@ -37,6 +37,7 @@
"url": "https://github.com/keplergl/kepler.gl.git"
},
"scripts": {
"bootstrap": "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true yarn",
"install:example": "cd examples/demo-app && yarn",
"install:web": "yarn install:example && cd website && yarn",
"install-and-start": "node ./scripts/install-and-start",
Expand Down Expand Up @@ -137,8 +138,8 @@
"@loaders.gl/polyfills": "^3.0.9",
"@luma.gl/test-utils": "^8.5.10",
"@nebula.gl/layers": "1.0.2-alpha.1",
"@probe.gl/env": "^3.0.1",
"@probe.gl/test-utils": "^3.0.1",
"@probe.gl/env": "^3.5.0",
"@probe.gl/test-utils": "^3.5.0",
"@testing-library/react-hooks": "^3.4.2",
"@types/d3-array": "^2.0.0",
"@types/d3-scale": "^3.2.2",
Expand Down Expand Up @@ -166,15 +167,11 @@
"eslint-plugin-react": "^7.13.0",
"eslint-plugin-react-hooks": "^4.1.0",
"gl": "^4.9.2",
"jest": "^26.6.1",
"jest-image-snapshot": "^4.2.0",
"jest-puppeteer": "^4.4.0",
"jsdom": "^16.4.0",
"json-loader": "^0.5.4",
"nyc": "^15.1.0",
"prettier": "1.19.1",
"progress-bar-webpack-plugin": "^2.1.0",
"puppeteer": "^2.1.1",
"react": "^16.8.4",
"react-dom": "^16.8.4",
"react-hot-loader": "^4.13.0",
Expand Down Expand Up @@ -248,14 +245,14 @@
]
},
"engines": {
"node": ">=12.0.0"
"node": ">=14"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.12",
"node": "14.21.1",
"yarn": "1.22.19"
}
}
4 changes: 2 additions & 2 deletions src/actions/package.json
Expand Up @@ -51,14 +51,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/cloud-providers/package.json
Expand Up @@ -38,14 +38,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/components/package.json
Expand Up @@ -126,14 +126,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/constants/package.json
Expand Up @@ -43,14 +43,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/deckgl-layers/package.json
Expand Up @@ -58,14 +58,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/layers/package.json
Expand Up @@ -75,14 +75,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/localization/package.json
Expand Up @@ -39,14 +39,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/processors/package.json
Expand Up @@ -49,14 +49,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/reducers/package.json
Expand Up @@ -71,14 +71,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/schemas/package.json
Expand Up @@ -49,14 +49,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/styles/package.json
Expand Up @@ -39,14 +39,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/table/package.json
Expand Up @@ -46,14 +46,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}
4 changes: 2 additions & 2 deletions src/tasks/package.json
Expand Up @@ -39,14 +39,14 @@
"instrument": false
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.21.1"
},
"maintainers": [
"Shan He <heshan0131@gmail.com>",
"Giuseppe Macri <gmacri@uber.com>"
],
"volta": {
"node": "12.22.0",
"node": "14.21.1",
"yarn": "1.22.17"
}
}

0 comments on commit 8312d06

Please sign in to comment.