[Bug] visual channels cannot read property 'label' of undefined (#1804)

* Fix crash: visualchannels cannot read property 'label' of undefined Signed-off-by: Shan He <heshan0131@gmail.com>
keplergl · May 4, 2022 · 8ac5bbc · 8ac5bbc
1 parent b7c6c8d
commit 8ac5bbc
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/layers/base-layer.ts b/src/layers/base-layer.ts
@@ -473,14 +473,17 @@ class Layer {
    * @returns
    */
   getVisualChannelDescription(key: string): VisualChannelDescription {
-    const label = this.visConfigSettings[this.visualChannels[key].range].label;
     // e.g. label: Color, measure: Vehicle Type
+    const channel = this.visualChannels[key];
+    if (!channel) return {label: '', measure: ''};
+    const rangeSettings = this.visConfigSettings[channel.range];
+    const fieldSettings = this.config[channel.field];
+    const label = rangeSettings?.label;
     return {
       label: typeof label === 'function' ? label(this.config) : label,
-      measure: this.config[this.visualChannels[key].field]
-        ? this.config[this.visualChannels[key].field].displayName ||
-          this.config[this.visualChannels[key].field].name
-        : this.visualChannels[key].defaultMeasure
+      measure: fieldSettings
+        ? fieldSettings.displayName || fieldSettings.name
+        : channel.defaultMeasure
     };
   }