[fix] serializeLayer fixes (#2343)

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
keplergl · Oct 2, 2023 · b5405f5 · b5405f5
1 parent 4383bff
commit b5405f5
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/reducers/src/vis-state-updaters.ts b/src/reducers/src/vis-state-updaters.ts
@@ -406,9 +406,11 @@ export function applyLayerConfigUpdater(
     return nextState;
   }
 
-  const serializedOldLayer = serializeLayer(oldLayer, state.schema);
+  // serializeLayer() might return null if the old layer is not valid,
+  // we should still apply the changes in that case
+  const serializedOldLayer = serializeLayer(oldLayer, state.schema) ?? {config: {}};
   const serializedNewLayer = serializeLayer(newLayer, state.schema);
-  if (!serializedNewLayer || !serializedOldLayer) {
+  if (!serializedNewLayer) {
     return state;
   }
   if (!isEqual(serializedOldLayer, serializedNewLayer)) {