[Fix] vis state schema column save undefined typeerror (#2211)

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> Co-authored-by: Jacob Wasilkowski <4933392+jwasilgeo@users.noreply.github.com>
keplergl · May 3, 2023 · c130a2f · c130a2f
1 parent d8a5def
commit c130a2f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/schemas/src/vis-state-schema.ts b/src/schemas/src/vis-state-schema.ts
@@ -382,7 +382,8 @@ class ColumnSchemaV1 extends Schema {
       [this.key]: Object.keys(columns).reduce(
         (accu, ckey) => ({
           ...accu,
-          [ckey]: columns[ckey].value
+          // if value is null, don't save it
+          ...(columns[ckey]?.value ? {[ckey]: columns[ckey].value} : {})
         }),
         {}
       )

diff --git a/test/helpers/mock-state.js b/test/helpers/mock-state.js
@@ -684,8 +684,7 @@ export const expectedSavedLayer1 = {
     color: [0, 0, 0],
     columns: {
       lat: 'gps_data.lat',
-      lng: 'gps_data.lng',
-      altitude: null
+      lng: 'gps_data.lng'
     },
     textLabel: [
       {
@@ -740,8 +739,7 @@ export const expectedLoadedLayer1 = {
     color: [0, 0, 0],
     columns: {
       lat: 'gps_data.lat',
-      lng: 'gps_data.lng',
-      altitude: null
+      lng: 'gps_data.lng'
     },
     hidden: false,
     isVisible: true,