[fix] Text labels: can't set prop to false/0 with multiple labels (#2354

)
keplergl · Oct 3, 2023 · cfee75a · cfee75a
1 parent 357f77a
commit cfee75a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/reducers/src/vis-state-updaters.ts b/src/reducers/src/vis-state-updaters.ts
@@ -575,11 +575,11 @@ function updateTextLabelPropAndValue(idx, prop, value, textLabel) {
 
   let newTextLabel = textLabel.slice();
 
-  if (prop && (value || textLabel.length === 1)) {
-    newTextLabel = textLabel.map((tl, i) => (i === idx ? {...tl, [prop]: value} : tl));
-  } else if (prop === 'field' && value === null && textLabel.length > 1) {
+  if (prop === 'field' && value === null && textLabel.length > 1) {
     // remove label when field value is set to null
     newTextLabel.splice(idx, 1);
+  } else if (prop) {
+    newTextLabel = textLabel.map((tl, i) => (i === idx ? {...tl, [prop]: value} : tl));
   }
 
   return newTextLabel;