Changed CONFIG_UPLOAD_MESSAGE to avoid confusion on single vs. multi jsons from previous maps #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 files of well log data and well log location data from Manville open dataset from Canada.
big zip wells
delete
delete
delete
Added sentence about going to vis.academy http://vis.academy/#/kepler.gl/setup for information on how to embed kepler.gl. This information is useful for people who want to share the map they've made with other people. Not everyone who comes to the readme will know that additional "how to" documentation is at vis.academy unless they're told.
Added link to vis.academy to readme
changed link in commit to http://vis.academy/#/kepler.gl/
Changed the CONFIG_UPLOAD_MESSAGE to make it clear that, to upload a previous map, you have to upload a "single" JSON that contains "both" the old data and all config. Trying to upload separate JSONs of previously used config and previously used data, which seems like a possible way forward with the old message, in fact doesn't work and results in a map that tries to load forever. This small change makes it clear that users should look for the option that exports both the config and data together in a single JSON. This is a radio button on the bottom of the export window that changes from the default state of separate exports to an 'everything' export.
heshan0131
pushed a commit
that referenced
this pull request
Dec 3, 2020
… default ones (#114) * SidePanel panels are now passed through only through props or default proprs. Removed CustomPanels default panels reference from SidePanel Signed-off-by: Giuseppe Macri <macri.giuseppe@gmail.com>
bjungs
pushed a commit
to imec-int/kepler.gl
that referenced
this pull request
Nov 14, 2022
fix: Changes use correct id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the CONFIG_UPLOAD_MESSAGE to make it clear that, to upload a previous map, you have to upload a "single" JSON that contains "both" the old data and all config.
Trying to upload separate JSONs of previously used config and previously used data, which seems like a possible way forward with the old message, in fact doesn't work and results in a map that tries to load forever.
This small change makes it clear that users should look for the option that exports both the config and data together in a single JSON. This is a radio button on the bottom of the export window that changes from the default state of separate exports to an 'everything' export.