-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Add Tracking #119
Merged
Merged
WIP Add Tracking #119
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8d22cfc
Add some tracking
benshope b7a0073
Make requested changes
benshope 26a4f69
Add analytics from information from Redux store
benshope a8a659c
Add tracking to export button click
benshope 4e8c972
Remove semicolons
benshope 91854b1
Revert "Remove semicolons"
benshope fb7b8c8
cleanup
benshope 7a1f6eb
minor
benshope 1395fec
make requested changes
benshope 5c9d2ea
minor
benshope ef86261
Fix tests
benshope b524783
Make requested changes
benshope 8b69583
Make requested changes
benshope 487e119
Make requested changes
benshope 2b6752e
rename
benshope 6f6cf30
minor
benshope c058336
Merge branch 'master' into tracking
benshope 676a476
Fix failing tests
benshope dfead5f
use gtag instead of ga, getting the correct filter type
heshan0131 c91136f
render Panel header as react class, so that props.logoComponent rende…
heshan0131 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PanelHeader can't be rendered as a pure functional component, because we can only use
this.props.logoComponent
syntax to render the local component, otherwise, react will interpretlogoComponent
as a tag