[Enhancement] Create factory for histogram and line chart, add brush handle to range brush #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heshan0131
changed the title
| } | ||
| } | ||
| `; | ||
| function HistogramPlotFactory() { |
There was a problem hiding this comment.
nit: missing new line
| const domain = useMemo(() => [histogram[0].x0, histogram[histogram.length - 1].x1], [ | ||
| histogram | ||
| ]); | ||
| const dataId = Object.keys(histogram[0]).filter(k => k !== 'x0' && k !== 'x1')[0]; |
There was a problem hiding this comment.
you can use useMemo here too
| fill: ${props => props.theme.textColor}; | ||
| } | ||
| `; | ||
| const StyledHint = styled.div` |
|
|
||
| const HintContent = ({x, y, format}) => ( | ||
| <StyledHint> | ||
| <div className="hint--x">{format(x)}</div> |
There was a problem hiding this comment.
could you pass the result of format(x) as input of this component?
| <div className="hint--x">{format(x)}</div> | ||
| <div className="row">{y}</div> | ||
| </StyledHint> | ||
| ); |
macrigiuseppe
approved these changes
Sep 18, 2020
| </StyledHint> | ||
| ); | ||
| const MARGIN = {top: 0, bottom: 0, left: 0, right: 0}; | ||
| function LineChartFactory() { |
src/components/common/range-brush.js
Outdated
| const h = 39; | ||
| const w = 4.5; | ||
| const y = (props.height - h) / 2; | ||
| // return `M0,57.3c2.5,0,4.5,2,4.5,4.5v29.3c0,2.5-2,4.5-4.5,4.5V57.3z` |
There was a problem hiding this comment.
remove commented lines
| hintFormatter = createSelector(this.domainSelector, domain => | ||
| getTimeWidgetHintFormatter(domain) | ||
| RangePlotFactory.deps = [RangeBrushFactory, HistogramPlotFactory, LineChartFactory]; | ||
| export default function RangePlotFactory(RangeBrush, HistogramPlot, LineChart) { |
| const wrapper = mountWithTheme(<RangePlot {...props} />); | ||
| }, 'Show not fail without histogram'); | ||
|
|
||
| // cant test D3 in jsDom for now |
There was a problem hiding this comment.
delete commented lines.
is testing only for render failures enough for this component?
There was a problem hiding this comment.
for now yea, better than nothing, we can't test d3 with jsDom at all, unless we created a bunch of utils for that component and only testing utils
Signed-off-by: Shan He <heshan0131@gmail.com>
brush interaction improve histogram Signed-off-by: Shan He <heshan0131@gmail.com> histogram plot tweaks Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
heshan0131
force-pushed
the
chart-n-brush
branch
from
dff426b
to
3e62f43
Compare
heshan0131
commented
Sep 18, 2020
| const domain = useMemo(() => [histogram[0].x0, histogram[histogram.length - 1].x1], [ | ||
| histogram | ||
| ]); | ||
| const dataId = Object.keys(histogram[0]).filter(k => k !== 'x0' && k !== 'x1')[0]; |
There was a problem hiding this comment.
it's very cheap operation, and the return value is a string, it's probably more expensive to memorize it than just call it
Signed-off-by: Shan He <heshan0131@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve histogram brush interaction
Signed-off-by: Shan He heshan0131@gmail.com