[Chores] Fixed security vulnerabilities and added new factories #1294
Conversation
Signed-off-by: Giuseppe Macri <macri.giuseppe@gmail.com>
… file Signed-off-by: Giuseppe Macri <macri.giuseppe@gmail.com>
Signed-off-by: Giuseppe Macri <macri.giuseppe@gmail.com>
macrigiuseppe
changed the title
macrigiuseppe
force-pushed
the
refactor_chores
branch
from
9976228
to
e7b3268
Compare
macrigiuseppe
changed the title
package.json
Outdated
| "lodash": "4.17.19", | ||
| "minimist": "1.2.3", | ||
| "node-fetch": "^2.6.1", | ||
| "tough-cookie": "^2.3.0" |
There was a problem hiding this comment.
The suggested resolution is to fix version to 2.3.0
macrigiuseppe
force-pushed
the
refactor_chores
branch
from
e7b3268
to
568f9d6
Compare
| @@ -103,7 +103,7 @@ const DropdownListWrapper = styled.div` | |||
| `; | |||
|
|
|||
| function LayerTypeListItemFactory() { | |||
| const LayerTypeListItem = ({value, isTile}) => ( | |||
| return ({value, isTile}) => ( | |||
There was a problem hiding this comment.
you will probably hahve the missing displayName error without the const LayerTypeListItem= it's also better for React devTools if we keep the declaration
There was a problem hiding this comment.
yeah i will update this one
Signed-off-by: Giuseppe Macri <macri.giuseppe@gmail.com>
macrigiuseppe
force-pushed
the
refactor_chores
branch
from
059c5e7
to
8a5a3fb
Compare
Signed-off-by: Giuseppe Macri <macri.giuseppe@gmail.com>
macrigiuseppe
force-pushed
the
refactor_chores
branch
from
d74e628
to
3d67256
Compare
Signed-off-by: Giuseppe Macri <macri.giuseppe@gmail.com>
Yeah i did. I re-ran and no differences. let me try to force push it again |
|
@heshan0131 pushed again, all kind-of versions are forced to use 6.0.3, see here: |
Signed-off-by: Giuseppe Macri <macri.giuseppe@gmail.com>
No description provided.