extend template for light theme #1305
Conversation
| @@ -1114,6 +1115,7 @@ export const theme = { | |||
| selectFontWeight, | |||
| selectColorLT, | |||
| selectFontWeightBold, | |||
| panelTabColor, | |||
There was a problem hiding this comment.
you need to also add panelTabColor to themeLT and themeBS and have it equals to the value of subtextColor in that theme
There was a problem hiding this comment.
Nice catch!. as both themes extends the theme variable I've added to themeLT and themeBS just the cases where that value was overwritten
src/styles/base.js
Outdated
| @@ -1310,6 +1312,7 @@ export const theme = { | |||
| lineHeight, | |||
| textColor, | |||
| textColorLT, | |||
| dataTabletextColor, | |||
There was a problem hiding this comment.
same as above
| @@ -1350,6 +1353,7 @@ export const theme = { | |||
| sliderHandleWidth, | |||
| sliderHandleColor, | |||
| sliderHandleTextColor, | |||
| sliderInactiveBorderColor, | |||
There was a problem hiding this comment.
same as above
src/styles/base.js
Outdated
| @@ -42,6 +42,7 @@ export const labelColorLT = '#6A7485'; | |||
|
|
|||
| export const textColor = '#A0A7B4'; | |||
| export const textColorLT = '#3A414C'; | |||
| export const dataTabletextColor = textColorLT; | |||
| @@ -1494,6 +1498,7 @@ export const themeLT = { | |||
| sliderBarColor: '#A0A7B4', | |||
| sliderBarBgd: '#D3D8E0', | |||
| sliderHandleColor: '#F7F7F7', | |||
There was a problem hiding this comment.
You created 4 new theme names
dataTabletextColor
sliderInactiveBorderColor
panelTabColor
dataTabletextColor
Stll missing some in temeLT and themeBS
Be diligent please
There was a problem hiding this comment.
Both themeLT and ThemeBS extends from theme. the variables has been added there(in theme). should I add them again in both themes?
There was a problem hiding this comment.
for the ones share same value between dark and light, you don't need to, but for the ones have different values you need to add them to light specifically
There was a problem hiding this comment.
This change was attended
No description provided.