Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Visual channel refactor generalize get accessor and updateTrigger #1338

Merged
merged 3 commits into from Dec 3, 2020

Conversation

heshan0131
Copy link
Contributor

  • Generalize getAttributeAccessors and getVisualChannelUpdateTriggers function across layers
  • refactor point arc line trip h3 geojson icon s2 layer to use visual channel methods
  • fix tests
    Signed-off-by: Shan He heshan0131@gmail.com

…ggers function across layers

* refactor point arc line trip h3 geojson icon s2 layer to use visual channel methods
* fix tests
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
@heshan0131 heshan0131 merged commit 524fc59 into master Dec 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the 1202-visualchanel-refactor branch December 3, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants