Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fixed color picker closure when selecting first custom palette value #1347

Merged
merged 1 commit into from
Dec 7, 2020
Merged

[Bug] Fixed color picker closure when selecting first custom palette value #1347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/side-panel/layer-panel/color-selector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class ColorSelector extends Component {
node = createRef();

handleClickOutside = e => {
if (this.props.colorUI && this.props.colorUI.showSketcher) {
if (this.props.colorUI && Number.isInteger(this.props.colorUI.showSketcher)) {
// if sketcher is open, let sketch to close itself first
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/side-panel/layer-panel/custom-palette.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ class CustomPalette extends Component {
e.stopPropagation();
}}
onChange={e => this._inputColorHex(index, e)}
id="input-layer-label"
id={`input-layer-label-${index}`}
/>
</StyledInlineInput>
<StyledTrash onClick={() => this._onColorDelete(index)}>
Expand Down