[Enhancement] automatically re-project GeoDataFrame to EPSG:4326 #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Fleischmann <martin@martinfleischmann.net>
heshan0131
approved these changes
Dec 7, 2020
|
Would be nice to add to documentation data format section explain what type of projection is supported: https://github.com/keplergl/kepler.gl/tree/master/docs/keplergl-jupyter#3-data-format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you pass a GeoDataFrame to Jupyter widget it gets automatically re-projected to EPSG:4326 if
crsis set and is different. That way user does not have to worry about projections when adding data to a map.I haven't found a test suite for Jupyter plugin, can you point me to the right place so I can write tests?
Closes #1209