[Enhancement] Show an error notification for errors in deck #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
igorDykhta
commented
Dec 10, 2020
•
igorDykhta
commented
- custom _onDeckError handler in map-container with error throttling to prevent multiple similar errors from appearing.
- additional logic for addNotification to update existing notifications.
ibgreen
reviewed
Dec 10, 2020
Signed-off-by: Igor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Igor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Igor Dykhta <dikhta.igor@gmail.com>
igorDykhta
force-pushed
the
igor/on-error-handler-for-deck
branch
from
a233c0a
to
28ddc0f
Compare
Signed-off-by: Igor Dykhta <dikhta.igor@gmail.com>
igorDykhta
force-pushed
the
igor/on-error-handler-for-deck
branch
from
5b7bfa3
to
a2fee8b
Compare
heshan0131
reviewed
Dec 16, 2020
| @@ -251,6 +256,28 @@ export default function MapContainerFactory(MapPopover, MapControl, Editor) { | |||
| setLayerBlending(gl, this.props.layerBlending); | |||
| }; | |||
|
|
|||
| _onError = (error, layer) => { | |||
| const errorMessage = `An error in deck.gl: ${error.message} in ${layer.id}`; | |||
There was a problem hiding this comment.
Will error from deck.gl always have a message?
heshan0131
approved these changes
Dec 16, 2020
Signed-off-by: Igor Dykhta <dikhta.igor@gmail.com>
igorDykhta
force-pushed
the
igor/on-error-handler-for-deck
branch
from
3e4019f
to
412c4c7
Compare
Signed-off-by: Igor Dykhta <dikhta.igor@gmail.com>
igorDykhta
force-pushed
the
igor/on-error-handler-for-deck
branch
from
ebee7bc
to
38c5a8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.