fix: save to map provider #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue keplergl#1374 Signed-off-by: VictorVelarde <victor.velarde@gmail.com>
VictorVelarde
force-pushed
the
fix-share-map
branch
from
a5efa7f
to
b4aedb9
Compare
|
Would you please @heshan0131 have a quick look into this one? Thx! |
|
Hi, any chance to review this small PR soon? Right now the whole panel is failing due to this issue. |
heshan0131
approved these changes
Jan 29, 2021
|
Thx Shan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1374
This should fix the error that appears when trying to Save map to a provider (Dropbox / Carto).
The error currently happens at MapContainer, lin 506. The presence of
mapControls.mapDrawis assumed, but that's not the case from this Providers > Save option flowThis small change looks enough to avoid the error and present the popup, but I'm not sure if it needs any other extra check.