[Bug] Geojson layer is not updated when dataset updated #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heshan0131
reviewed
Jul 8, 2021
src/layers/base-layer.js
Outdated
| @@ -873,7 +873,7 @@ class Layer { | |||
| const dataUpdateTriggers = this.getDataUpdateTriggers(layerDataset); | |||
| const triggerChanged = this.getChangedTriggers(dataUpdateTriggers); | |||
|
|
|||
| if (triggerChanged.getMeta) { | |||
| if (triggerChanged.getMeta || triggerChanged.getData) { | |||
There was a problem hiding this comment.
for this case, you should change getDataUpdateTriggers in base-layer, and add allData to the return,
return {
getData: {datasetId: id, allData, columns, filteredIndex},
getMeta: {datasetId: id, allData, columns},
...
}There was a problem hiding this comment.
sounds good, will do
There was a problem hiding this comment.
@heshan0131 updated as requested
Signed-off-by: Vladi Bilonenko <bilonenko.v@gmail.com>
delfrrr
force-pushed
the
fix-geojson-update
branch
from
57fdaee
to
74ee310
Compare
heshan0131
approved these changes
Jul 9, 2021
|
@heshan0131 so what are the next steps? is there anything I can do t get this merged? I guess you need to approve some workflows to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation when
addDataToMapis called second time for the samedataset.info.id,geojson-layerwill not update correctly. BecausecalculateDataAttributein GeoJSON layer require precalculatedthis.dataToFeatureproperty which calculated inupdateLayerMeta. So If metadata did not change (same columns but different rows),updateLayerMetawill not be called and layer will not update correctly.Given that
updateLayerMetatakesallDataas param, it will be logical to call it when data updates.