Make showing User Guide link optional for jupyter widget #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qiusheng Wu <giswqs@gmail.com>
giswqs
changed the title
heshan0131
approved these changes
Jul 29, 2021
|
Can you add this to the documentation here? |
Signed-off-by: Qiusheng Wu <giswqs@gmail.com>
|
@heshan0131 I have added the following to the documentation. By default, the User Guide URL (https://docs.kepler.gl/docs/keplergl-jupyter) will be printed when a map is created. To hide the User Guide URL, set # Hide the User Guide URL
from keplergl import KeplerGl
map_1 = KeplerGl(show_docs=False)
map_1 |
heshan0131
reviewed
Jul 29, 2021
docs/keplergl-jupyter/README.md
Outdated
| @@ -90,6 +90,16 @@ map_1 | |||
|
|
|||
| ![empty map][empty_map] | |||
|
|
|||
| By default, the User Guide URL (<https://docs.kepler.gl/docs/keplergl-jupyter>) will be printed when a map is created. To hide the User Guide URL, set `show_docs=False`. | |||
There was a problem hiding this comment.
Move this to after __config__ on line 77, because it is an additional argument for KeplerGl
Signed-off-by: Qiusheng Wu <giswqs@gmail.com>
|
target release |
lixun910
pushed a commit
to lixun910/kepler.gl
that referenced
this pull request
Aug 13, 2021
…eplergl#1559) * Make show User Guide link optional for jupyter * Updated README with shows_docs parameter Signed-off-by: Qiusheng Wu <giswqs@gmail.com> Signed-off-by: Xun Li <lixun910@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the issue #1553. By default, the User Guide URL will always be printed when a map is created. Users can set
KeplerGl(show_docs=False)to hide the User Guide URL if needed.Before:
After: