[Feat] Add MapsLayoutFactory for custom split map layouts #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heshan0131
commented
Aug 29, 2021
•
heshan0131
commented
- Add MapsLayoutFactory for custom split map layouts
- Avoid manual calculation of the sizes of the map-containers and positioning them with CSS instead
- Add observeDimensions and useDimensions to allow components to listen to their size changes
- Fixed the issue with the HistogramPlot not being updated by adding a resize observer to RangeSlider
- Fix Crash on Double-click in dual map
- Fix: Pinning a tooltip moves it to the top left of the screen
- Changed width > 0 || height > 0 to width > 0 && height > 0
- Fix formatting
- Fix: Map layers can't be moved on top
- Add MapsLayoutFactory for custom split map layouts - Avoid manual calculation of the sizes of the map-containers and positioning them with CSS instead - Add observeDimensions and useDimensions to allow components to listen to their size changes - Fixed the issue with the HistogramPlot not being updated by adding a resize observer to RangeSlider - Crash on Double-click in dual map - Fix: Pinning a tooltip moves it to the top left of the screen - Changed width > 0 || height > 0 to width > 0 && height > 0 - Fix: Crash on Double-click in dual map - Fix formatting - Fix: Map layers can't be moved on top (#210) Signed-off-by: Ilya Boyandin <iboyandin@foursquare.com>
heshan0131
force-pushed
the
0828-map-layout
branch
from
ba5b7ae
to
7c15997
Compare
ilyabo
approved these changes
Aug 29, 2021
is that in kepler or studio? |
|
@heshan0131 Ah indeed, it was a Studio fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.